Skip to content

meta: add v8 team #38566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

meta: add v8 team #38566

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

cc @nodejs/v8

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label May 6, 2021
richardlau
richardlau reviewed May 6, 2021
View reviewed changes
@gengjiawen gengjiawen requested review from richardlau and ryzokuken May 6, 2021 12:44
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label May 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

gengjiawen added a commit that referenced this pull request May 8, 2021
@gengjiawen
meta: add v8 team
52e4fb5 
PR-URL: #38566
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gengjiawen
Copy link
Member Author

Landed in 52e4fb5

@gengjiawen gengjiawen closed this May 8, 2021
@gengjiawen gengjiawen deleted the v8_codeowner branch May 8, 2021 07:51
targos pushed a commit that referenced this pull request May 17, 2021
@gengjiawen @targos
meta: add v8 team
90b640e 
PR-URL: #38566
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 18, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@gengjiawen @targos
meta: add v8 team
d72015f 
PR-URL: #38566
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@gengjiawen @targos
meta: add v8 team
8c8c21b 
PR-URL: #38566
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@gengjiawen @targos
meta: add v8 team
e0d7529 
PR-URL: #38566
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@gengjiawen @targos
meta: add v8 team
e94e0b4 
PR-URL: #38566
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gengjiawen @jasnell @addaleax @cjihrig @richardlau @gireeshpunathil @ryzokuken