Skip to content

Conversation

JayFate
Copy link
Contributor

@JayFate JayFate commented May 27, 2021

update setup-node@v1 to setup-node@v2.

Signed-off-by: pengjie [email protected]

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 27, 2021
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @richardlau's comment addressed.

@gengjiawen gengjiawen requested a review from richardlau May 28, 2021 12:11
gengjiawen pushed a commit that referenced this pull request May 29, 2021
Signed-off-by: pengjie <[email protected]>

PR-URL: #38825
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@gengjiawen
Copy link
Member

Landed in 4c508f5.

Thanks for the contribution :)

@gengjiawen gengjiawen closed this May 29, 2021
danielleadams pushed a commit that referenced this pull request May 31, 2021
Signed-off-by: pengjie <[email protected]>

PR-URL: #38825
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request May 31, 2021
richardlau pushed a commit that referenced this pull request Jul 16, 2021
Signed-off-by: pengjie <[email protected]>

PR-URL: #38825
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
Signed-off-by: pengjie <[email protected]>

PR-URL: #38825
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
Signed-off-by: pengjie <[email protected]>

PR-URL: #38825
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Signed-off-by: pengjie <[email protected]>

PR-URL: nodejs#38825
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants