Skip to content

Conversation

jameshilliard
Copy link

@github-actions github-actions bot added needs-ci PRs that need a full CI run. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Jul 19, 2021
@richardlau richardlau changed the title Fix build with ICU >= 68. [v12.x] Fix build with ICU >= 68. Jul 19, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jul 19, 2021

Is it the same as v8/v8@035c305? If so, can you apply the upstream commit instead (git node v8 backport 035c305ce7761f51328b45f1bd83e26aef267c9d). See https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches for detailed instructions.

@richardlau
Copy link
Member

Is it the same as v8/v8@035c305? If so, can you apply the upstream commit instead (git node v8 backport 035c305ce7761f51328b45f1bd83e26aef267c9d). See https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md#backporting-to-abandoned-branches for detailed instructions.

For history, we had to patch up v8/v8@035c305 for 14.x so that LTS Node.js could continue to build against the existing ICU versions #39068.

@jameshilliard
Copy link
Author

Is it the same as v8/v8@035c305?

I think so, but I tried to maintain backwards compat with older ICU versions.

@jameshilliard
Copy link
Author

For history, we had to patch up v8/v8@035c305 for 14.x so that LTS Node.js could continue to build against the existing ICU versions #39068.

Made a version based on that in #39451 in case that's preferable.

@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

I've landed #39451 instead. Thanks.

@richardlau richardlau closed this Jul 23, 2021
@jameshilliard jameshilliard deleted the fix-icu-68 branch July 23, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants