[v14.x-backport] report: generates report on threads with no isolates #39515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
legendecas
requested review from
cjihrig,
gireeshpunathil and
himself65
and removed request for
cjihrig and
gireeshpunathil
legendecas
force-pushed
the
backport-to-14/38994
branch
from
bfb6773 to
60b98e8
Compare
legendecas
added
node-api
richardlau
force-pushed
the
v14.x-staging
branch
from
073941c to
0061e5d
Compare
|
Can you please rebase? |
BethGriggs
force-pushed
the
v14.x-staging
branch
from
78bb65e to
73e6781
Compare
|
ping @legendecas |
legendecas
force-pushed
the
backport-to-14/38994
branch
from
60b98e8 to
550f5d9
Compare
|
@targos updated! :) |
MylesBorins
force-pushed
the
v14.x-staging
branch
from
b3f51ee to
327838d
Compare
napi_fatal_error and node watchdog trigger fatal error but rather running on a thread that hold no current isolate. PR-URL: nodejs#38624 Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#38994 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
force-pushed
the
backport-to-14/38994
branch
from
550f5d9 to
3cab19c
Compare
targos
pushed a commit
that referenced
this pull request
Sep 3, 2021
napi_fatal_error and node watchdog trigger fatal error but rather running on a thread that hold no current isolate. PR-URL: #38624 Backport-PR-URL: #39515 Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2021
PR-URL: #38994 Backport-PR-URL: #39515 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in a74032a...f69c934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport contains following commits:
report: generates report on threads with no isolates
PR-URL: #38994
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: James M Snell [email protected]
src: fix fatal errors when a current isolate not exist
napi_fatal_error and node watchdog trigger fatal error but rather
running on a thread that hold no current isolate.
PR-URL: #38624
Reviewed-By: Michael Dawson [email protected]