Skip to content

meta: consolidate AUTHORS entry for mikemaccana #40051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entry for mikemaccana #40051

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 9, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 9, 2021
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 9, 2021
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Sep 11, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@github-actions
Copy link
Contributor

Landed in 3e8eda2...e267467

@github-actions github-actions bot closed this Sep 11, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entry for mikemaccana
e267467 
PR-URL: #40051
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entry for mikemaccana
29964e6 
PR-URL: #40051
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entry for mikemaccana
2a41530 
PR-URL: #40051
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
@Trott Trott deleted the mm-update branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

+1 more reviewer

@evanlucas evanlucas evanlucas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @jasnell @evanlucas @lpinca @tniessen @nodejs-github-bot