doc: clarify that ObjectWrap requires manual cleanup on shutdown #40074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
Flarna
force-pushed
the
doc-objectwrap
branch
from
eb1e2c8 to
618e642
Compare
Flarna
changed the title
Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks.
Flarna
force-pushed
the
doc-objectwrap
branch
from
618e642 to
3146ba1
Compare
lpinca
approved these changes
Sep 10, 2021
mscdex
reviewed
Sep 11, 2021
Flarna
force-pushed
the
doc-objectwrap
branch
from
ff8d9d3 to
8ed33ec
Compare
Flarna
added
the
author ready
mhdawson
reviewed
Sep 14, 2021
jasnell
approved these changes
Sep 15, 2021
Flarna
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 8468bdb...7b4e6d4 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. PR-URL: #40074 Fixes: #38816 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. PR-URL: #40074 Fixes: #38816 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks. PR-URL: #40074 Fixes: #38816 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks.
fixes: #38816