build: remove duplicate check for authors.yml #40393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update-authors.js will print if there are duplicates in the new entries so we can remove the (not working) duplication check in the authors.yml file. It would still be nice to get the information about duplicates into the body of the GitHub PR so no one has to manually check for duplicates (by either examining the file or looking at the Actions output), but that can be a future improvement.
nodejs-github-bot
added
the
meta
targos
approved these changes
Oct 10, 2021
Mesteery
added
the
author ready
aduh95
approved these changes
Oct 10, 2021
Lxxyx
approved these changes
Oct 11, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 012152d...73c3885 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
update-authors.js will print if there are duplicates in the new entries so we can remove the (not working) duplication check in the authors.yml file. It would still be nice to get the information about duplicates into the body of the GitHub PR so no one has to manually check for duplicates (by either examining the file or looking at the Actions output), but that can be a future improvement. PR-URL: #40393 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
update-authors.js will print if there are duplicates in the new entries so we can remove the (not working) duplication check in the authors.yml file. It would still be nice to get the information about duplicates into the body of the GitHub PR so no one has to manually check for duplicates (by either examining the file or looking at the Actions output), but that can be a future improvement. PR-URL: #40393 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update-authors.js will print if there are duplicates in the new entries
so we can remove the (not working) duplication check in the authors.yml
file. It would still be nice to get the information about duplicates
into the body of the GitHub PR so no one has to manually check for
duplicates (by either examining the file or looking at the Actions
output), but that can be a future improvement.