doc: update BUILDING.md section on running tests #40933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Member
|
LGTM except for the typo in the commit message title. :) |
Trott
changed the title
Member
Author
Whoops! Fixed. |
VoltrexKeyva
approved these changes
Nov 23, 2021
aduh95
reviewed
Nov 23, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I realize this was introduced prior to this PR, but shouldn't we be using bash instead of text? And shouldn't we avoid to name the python executable (which is named python3 in many systems I believe)?
Trott
force-pushed
the
running-tests
branch
6 times, most recently
from
384f16f to
82851fd
Compare
Member
Author
|
@aduh95 I believe I've addressed all your suggestions. If I've missed something, please let me know! |
Trott
commented
Nov 23, 2021
aduh95
approved these changes
Nov 23, 2021
Trott
force-pushed
the
running-tests
branch
2 times, most recently
from
442d353 to
82e292b
Compare
tniessen
approved these changes
Nov 23, 2021
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a5d3449 |
targos
pushed a commit
that referenced
this pull request
Nov 26, 2021
Refs: #40920 PR-URL: #40933 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Refs: #40920 PR-URL: #40933 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: #40920 PR-URL: #40933 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #40920