- 
          
- 
        Couldn't load subscription status. 
- Fork 33.6k
deps: V8: cherry-pick 3b6b21f595f6 #41457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
    | Review requested: 
 | 
              
                    gengjiawen
  
              
              approved these changes
              
                  
                    Jan 10, 2022 
                  
              
              
            
            
              
                    richardlau
  
              
              approved these changes
              
                  
                    Jan 10, 2022 
                  
              
              
            
            
              
                    addaleax
  
              
              approved these changes
              
                  
                    Jan 10, 2022 
                  
              
              
            
            
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Jan 10, 2022 
                  
              
              
            
            
              
                    tniessen
  
              
              approved these changes
              
                  
                    Jan 10, 2022 
                  
              
              
            
            
      
        
      
      
  
    20 tasks
  
  This was referenced Jan 13, 2022 
      
              
                    RaisinTen
  
              
              approved these changes
              
                  
                    Jan 14, 2022 
                  
              
              
            
            
| Landed in f1ac552 | 
      
        
      
      
  
    26 tasks
  
    
  targos 
      added a commit
      that referenced
      this pull request
    
      Jan 16, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: #41402
PR-URL: #41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  mawaregetsuka 
      pushed a commit
        to mawaregetsuka/node
      that referenced
      this pull request
    
      Jan 17, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  targos 
      added a commit
        to targos/node
      that referenced
      this pull request
    
      Jan 18, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  thedull 
      pushed a commit
        to thedull/node
      that referenced
      this pull request
    
      Jan 18, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  targos 
      added a commit
      that referenced
      this pull request
    
      Jan 20, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: #41402
PR-URL: #41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  targos 
      added a commit
        to targos/node
      that referenced
      this pull request
    
      Jan 20, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  targos 
      added a commit
        to targos/node
      that referenced
      this pull request
    
      Jan 29, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  Linkgoron 
      pushed a commit
        to Linkgoron/node
      that referenced
      this pull request
    
      Jan 31, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  Linkgoron 
      pushed a commit
        to Linkgoron/node
      that referenced
      this pull request
    
      Jan 31, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  danielleadams 
      pushed a commit
      that referenced
      this pull request
    
      Feb 1, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: #41402
PR-URL: #41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
      
     Merged
  
    
  targos 
      added a commit
        to targos/node
      that referenced
      this pull request
    
      Feb 1, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  targos 
      added a commit
      that referenced
      this pull request
    
      Feb 2, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: #41402
PR-URL: #41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
    
  VoltrexKeyva 
      pushed a commit
        to VoltrexKeyva/node
      that referenced
      this pull request
    
      Feb 3, 2022 
    
    
      
  
    
      
    
  
Original commit message:
    [liftoff] Allow bailout for missing ARMv7
    The bailout is there explicitly in the code, so we should allow it in
    {CheckBailoutAllowed}.
    [email protected]
    Bug: v8:12527
    Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915
    Reviewed-by: Andreas Haas <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#78515}
Refs: v8/v8@3b6b21f
Fixes: nodejs#41402
PR-URL: nodejs#41457
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    build
  Issues and PRs related to build files or the CI. 
  
    needs-ci
  PRs that need a full CI run. 
  
    v8 engine
  Issues and PRs related to the V8 dependency. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Original commit message:
Refs: v8/v8@3b6b21f
Fixes: #41402