Skip to content

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jun 1, 2022

src/node_crypto.* has been refactored into many smaller files that are in src/crypto.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen
Copy link
Member Author

tniessen commented Jun 1, 2022

Also, @nodejs/crypto has very few active members who frequently review C++ changes, and we often have changes that require C++ knowledge but not so much crypto-specific knowledge. Maybe we should have a team to ping for C++ changes that do not require familiarity with a specific subsystem?

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0ef81d1 into nodejs:master Jun 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 0ef81d1

italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
PR-URL: nodejs#43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants