Skip to content

test: use async/await in test-debugger-exceptions #44690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2022
Merged

test: use async/await in test-debugger-exceptions #44690

merged 1 commit into from
Sep 30, 2022

Conversation

pete3249
Copy link
Contributor

@pete3249 pete3249 commented Sep 16, 2022 •
edited
Loading

Changes the promises to async/await in test/parallel/test-debugger-exceptions.js.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@Trott Trott added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46631/

@Trott Trott force-pushed the test-debugger-exceptions branch from af06765 to 700a062 Compare September 23, 2022 23:44
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
@Trott Trott removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
Trott
Trott reviewed Sep 23, 2022
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46737/

@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46881/

@Trott Trott force-pushed the test-debugger-exceptions branch from ddd830d to 6faf7d3 Compare September 28, 2022 01:45
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46882/

@Trott Trott force-pushed the test-debugger-exceptions branch from 6faf7d3 to 9725a02 Compare September 28, 2022 01:53
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46884/

@github-actions github-actions bot mentioned this pull request Sep 29, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46921/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46941/

@Trott
Copy link
Member

Trott commented Sep 29, 2022 •
edited
Loading

Not sure why the test-worker-prof test is failing on Windows over and over on Jenkins, but I'll try rebasing and force pushing to hope it fixes it.

@Trott Trott changed the title src: change promises to async await test: change promises to async await Sep 29, 2022
@Trott Trott changed the title test: change promises to async await test: use async/await in test-debugger-exceptions Sep 29, 2022
@Trott Trott force-pushed the test-debugger-exceptions branch from 9725a02 to 97d60f9 Compare September 29, 2022 18:45
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46945/

@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Open
17 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit bf0c312 into nodejs:main Sep 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in bf0c312

@Trott
Copy link
Member

Trott commented Sep 30, 2022

Thanks for the contribution! 🎉

This was referenced Oct 1, 2022
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@pete3249 @danielleadams
test: use async/await in test-debugger-exceptions
ee3c6a4 
PR-URL: #44690
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pete3249 @nodejs-github-bot @Trott