doc: avoid hiding by navigation bar in anchor jumping #45131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #42286 ? |
aduh95
approved these changes
May 12, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in b0bd534 |
targos
pushed a commit
that referenced
this pull request
May 21, 2024
PR-URL: #45131 Fixes: #42286 Reviewed-By: Antoine du Hamel <[email protected]>
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#45131 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#45131 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <[email protected]>
|
I think that navigating the documentation is significantly broken now Not sure if it's by this change, or by combination with smooth scrolling, or by any other changes in the doc structure, but navigating 22.x docs just scrolls to incorrect locations
|
|
However, this issue still exists in the Node 17 documentation. I submitted this PR to specifically address the documentation for Node 17. |
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #45131 Fixes: #42286 Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #45131 Fixes: #42286 Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction link: https://nodejs.org/docs/latest-v17.x/api/url.html#class-urlsearchparams
Fixes: #42286