Skip to content

crypto: clear OpenSSL error queue after calling X509_check_private_key() #45495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2022
Merged

crypto: clear OpenSSL error queue after calling X509_check_private_key() #45495

merged 1 commit into from
Nov 19, 2022

Conversation

panva
Copy link
Member

@panva panva commented Nov 17, 2022

Fixes: #45485

@panva panva added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 17, 2022
@panva panva mentioned this pull request Nov 17, 2022
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva mentioned this pull request Nov 17, 2022
Merged
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47997/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2022
@github-actions github-actions bot mentioned this pull request Nov 18, 2022
Open
12 tasks
@panva panva requested a review from anonrig November 18, 2022 05:15
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit b61603f into nodejs:main Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b61603f

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@panva @ruyadorno
crypto: clear OpenSSL error queue after calling X509_check_private_key()
bd3accc 
Fixes: #45485
PR-URL: #45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@panva @marco-ippolito
crypto: clear OpenSSL error queue after calling X509_check_private_key()
de7c0ae 
Fixes: nodejs#45485
PR-URL: nodejs#45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
@mjones-vsat mjones-vsat mentioned this pull request Dec 16, 2022
Closed
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: clear OpenSSL error queue after calling X509_check_private_key()
f13d29b 
Fixes: #45485
PR-URL: #45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: clear OpenSSL error queue after calling X509_check_private_key()
25425d0 
Fixes: #45485
PR-URL: #45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@panva panva deleted the crypto-fix-45485 branch January 2, 2023 22:07
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: clear OpenSSL error queue after calling X509_check_private_key()
f27ebab 
Fixes: #45485
PR-URL: #45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@panva @danielleadams
crypto: clear OpenSSL error queue after calling X509_check_private_key()
f5bfa73 
Fixes: #45485
PR-URL: #45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@panva @danielleadams
crypto: clear OpenSSL error queue after calling X509_check_private_key()
a7123fd 
Fixes: #45485
PR-URL: #45495
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
oraluben pushed a commit to oraluben/node that referenced this pull request Mar 14, 2023
@panva @oraluben
crypto: clear OpenSSL error queue after calling X509_check_private_key()
e67b549 
Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/375
CVE-ID: CVE-2023-23919
Fixes: nodejs/node#45485
PR-URL: nodejs/node#45495
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
oraluben pushed a commit to oraluben/node that referenced this pull request Mar 17, 2023
@panva @oraluben
crypto: clear OpenSSL error queue after calling X509_check_private_key()
5fbc980 
Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/375
CVE-ID: CVE-2023-23919
Fixes: nodejs/node#45485
PR-URL: nodejs/node#45495
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
m0th3rch1p pushed a commit to m0th3rch1p/node that referenced this pull request Jul 20, 2025
@panva @richardlau
crypto: clear OpenSSL error queue after calling X509_check_private_key()
160adb7 
Backport-PR-URL: nodejs-private/node-private#375
CVE-ID: CVE-2023-23919
Fixes: nodejs#45485
PR-URL: nodejs#45495
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crypto: X509Certificate.checkPrivateKey() used with a non-matching key makes the next call to createPrivateKey() fail.

4 participants

@panva @nodejs-github-bot @anonrig @tniessen