Skip to content

build: add extra semi check #46194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

build: add extra semi check #46194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f10b0
build: add extra semi check
gengjiawen Jan 13, 2023
5eb2c67
deps: cherrypick simdutf patch
gengjiawen Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/simdutf/simdutf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1599,7 +1599,7 @@ class implementation {
*
* @return a mask of all required `internal::instruction_set::` values
*/
virtual uint32_t required_instruction_sets() const { return _required_instruction_sets; };
virtual uint32_t required_instruction_sets() const { return _required_instruction_sets; }


/**
Expand Down
1 change: 1 addition & 0 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
'-W',
'-Wno-unused-parameter',
'-Werror=undefined-inline',
'-Werror=extra-semi',
],
},

Expand Down
2 changes: 1 addition & 1 deletion node.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

'conditions': [
[ 'clang==1', {
'cflags': [ '-Werror=undefined-inline', ]
'cflags': [ '-Werror=undefined-inline', '-Werror=extra-semi']
}],
[ '"<(_type)"=="executable"', {
'msvs_settings': {
Expand Down