[WİP]test: added the requireStack to loader.js #46586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
anonrig
reviewed
Feb 9, 2023
anonrig
reviewed
Feb 9, 2023
RaisinTen
reviewed
Feb 10, 2023
mertcanaltin
requested review from
anonrig
and removed request for
RaisinTen
BridgeAR
requested changes
Feb 20, 2023
lib/internal/modules/cjs/loader.js
Outdated
| err.path = path.resolve(requestPath, 'package.json'); | ||
| err.requestPath = originalPath; | ||
| // TODO(BridgeAR): Add the requireStack as well. | ||
|
|
There was a problem hiding this comment.
The requireStack must be added to this error. That does not seem to be addressed here?
lib/internal/modules/cjs/loader.js
Outdated
| 'Please either fix that or report it to the module author', | ||
| 'DeprecationWarning', | ||
| 'DEP0128', | ||
| { requireStack }, |
There was a problem hiding this comment.
I am not certain what the intent here is. The warning seems independent from the TODO entry above?
BridgeAR
reviewed
Feb 20, 2023
|
Like Module._findPath and we think that changing the args list of this function will probably break some userspace packages. Do you have any comments on this? ❤️ @BridgeAR @anonrig 🎸 update : In the code block below, when the tryExtensions() function returns false, in the part where tryExtensions() is tried again with another parameter combination, I created a require stack when necessary |
mertcanaltin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// TODO(BridgeAR): Add the requireStack as well.
I also added the require stack @RaisinTen