Skip to content

Conversation

meixg
Copy link
Member

@meixg meixg commented Feb 27, 2023

Update wpt url test. Added case for #46850 by web-platform-tests/wpt#38711.

Rely on #46853

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2023
@anonrig
Copy link
Member

anonrig commented Mar 1, 2023

Can you update the pull request @meixg? The tests are failing of it.

@meixg meixg force-pushed the url-quote-escape branch from 94c4683 to 10d8755 Compare March 1, 2023 01:49
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit f652f7b into nodejs:main Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f652f7b

@meixg meixg deleted the url-quote-escape branch March 3, 2023 03:24
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
PR-URL: nodejs#46860
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #46860
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants