lib, doc: standardize params in PerformanceObserver.observe #47025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umuoy1
changed the title
umuoy1
force-pushed
the
oberve-type-check
branch
from
3616f7d to
e34733d
Compare
umuoy1
changed the title
legendecas
added
semver-major
legendecas
reviewed
Mar 31, 2023
| }); | ||
| }, "Calling observe() with type and entryTypes should throw a TypeError"); | ||
|
|
||
| test(() => { |
There was a problem hiding this comment.
Changes in WPT should be submitted to the upstream first: https://github.com/web-platform-tests/wpt.
In the meantime, you can move this test case to test/parallel/ directory. That's where Node.js' test cases are located at.
There was a problem hiding this comment.
Have the changes been upstreamed?
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes missing validation when options.buffered and options.entryType are both set in PerformanceObserver.observe
https://www.w3.org/TR/performance-timeline/#observe-method