deps: V8: cherry-pick 215ccd593edb #47212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
Use FlagValue::value() in SLOW_DCHECK
Previously SLOW_DCHECK used the non-constexpr bool() operator
of FlagValue, which cannot be used in constexpr. Switch to
FlagValue::value() instead for make it compile in constexpr.
Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86611}
Refs: v8/v8@215ccd5
|
Review requested:
|
nodejs-github-bot
added
build
targos
approved these changes
Mar 22, 2023
debadree25
reviewed
Mar 22, 2023
debadree25
approved these changes
Mar 22, 2023
richardlau
approved these changes
Mar 22, 2023
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f523979 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Original commit message:
Use FlagValue::value() in SLOW_DCHECK
Previously SLOW_DCHECK used the non-constexpr bool() operator
of FlagValue, which cannot be used in constexpr. Switch to
FlagValue::value() instead for make it compile in constexpr.
Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86611}
Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Original commit message:
Use FlagValue::value() in SLOW_DCHECK
Previously SLOW_DCHECK used the non-constexpr bool() operator
of FlagValue, which cannot be used in constexpr. Switch to
FlagValue::value() instead for make it compile in constexpr.
Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86611}
Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Original commit message:
Use FlagValue::value() in SLOW_DCHECK
Previously SLOW_DCHECK used the non-constexpr bool() operator
of FlagValue, which cannot be used in constexpr. Switch to
FlagValue::value() instead for make it compile in constexpr.
Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#86611}
Refs: v8/v8@215ccd5
PR-URL: #47212
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
./configure --v8-non-optimized-debugis broken without this patch, which makes debugging into V8 harder. The upstream works fine without this probably because there V8 is always built using a specified version of clang but for Node.js we need to float this until the patch gets in with the next V8 update.Original commit message:
Refs: v8/v8@215ccd5