doc: update socket.remote* properties documentation #48139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
bnoordhuis
approved these changes
May 23, 2023
ShogunPanda
approved these changes
May 23, 2023
Trott
approved these changes
May 23, 2023
aymen94
approved these changes
May 24, 2023
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5275843 |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
May 26, 2023
Fixes: nodejs#48061 PR-URL: nodejs#48139 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
Fixes: #48061 PR-URL: #48139 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Fixes: #48061 PR-URL: #48139 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Fixes: nodejs#48061 PR-URL: nodejs#48139 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes: nodejs#48061 PR-URL: nodejs#48139 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes: nodejs#48061 PR-URL: nodejs#48139 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48061
Just added in that
socket.remoteFamilyandsocket.remotePortmay be undefined as well if the socket is destroyed.