Skip to content

url: revokeObjectURL should throw an error when no parameter is provided #50925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

url: revokeObjectURL should throw an error when no parameter is provided #50925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b7ea6b
Fixed URL Check
strawberrywz Nov 26, 2023
6da91f5
src: fix typos in url.js
strawberrywz Nov 26, 2023
2379b0a
Fixes: https://github.com/nodejs/node/issues/50432
strawberrywz Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,9 @@ function installObjectURLMethods() {
}

function revokeObjectURL(url) {
if (arguments.length == 0) {
throw new ERR_MISSING_ARGS('url');
}
bindingBlob.revokeObjectURL(`${url}`);
}

Expand Down
6 changes: 6 additions & 0 deletions package-lock.json
View file
Open in desktop
Copy link
Member

@himself65 himself65 Nov 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not supposed to have. Please remove it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I add a test case? I also see an error which says the following:
Check failure on line 1107 in lib/internal/url.js
GitHub Actions
/ lint-js-and-md
Expected '===' and instead saw '=='

am I to fix this as well or?

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.