Skip to content

fs: throw fchownSync error from c++ #51075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

fs: throw fchownSync error from c++ #51075

merged 1 commit into from
Dec 12, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Dec 6, 2023

Ref: nodejs/performance#106

#49920 seems to be abandoned.

cc @nodejs/fs

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Dec 6, 2023
@anonrig anonrig mentioned this pull request Dec 6, 2023
Open
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56139/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56145/

@anonrig
Copy link
Member Author

anonrig commented Dec 7, 2023

cc @nodejs/fs @nodejs/cpp-reviewers appreciate if you could leave a review.

CanadaHonk
CanadaHonk approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@CanadaHonk CanadaHonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen
Copy link
Member

tniessen commented Dec 7, 2023

I believe @H4ad suggested to re-run benchmarks for these changes in nodejs/performance#106.

@H4ad
Copy link
Member

H4ad commented Dec 7, 2023

@anonrig Can you update the benchmark of bench-chownSync.js to include this method? Just to see if those changes are still relevant compared to the new improvements made on errors.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56194/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3551dc0 into nodejs:main Dec 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3551dc0

@anonrig
Copy link
Member Author

anonrig commented Dec 12, 2023

@anonrig Can you update the benchmark of bench-chownSync.js to include this method? Just to see if those changes are still relevant compared to the new improvements made on errors.

I missed this comment. Sorry I just realized that I didn't comment on this.

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@anonrig @RafaelGSS
fs: throw fchownSync error from c++
35e8f26 
PR-URL: #51075
Refs: nodejs/performance#106
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@anonrig @richardlau
fs: throw fchownSync error from c++
afd5d67 
PR-URL: #51075
Refs: nodejs/performance#106
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@CanadaHonk CanadaHonk CanadaHonk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig @nodejs-github-bot @tniessen @H4ad @Qard @jasnell @CanadaHonk