Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/timezone-update.yml.

Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#time-zone-data

To test, build node off this branch & log the version of tz using

console.log(process.versions.tz)

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 10, 2023
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of the timezone data is already in the version of ICU we are using. The automation script needs to be updated to prevent opening PRs in these cases.

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Dec 10, 2023
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2023
PR-URL: #51178
Refs: #51107
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos closed this Dec 23, 2023
@targos targos deleted the actions/timezone-update branch December 23, 2023 10:26
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51178
Refs: #51107
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51178
Refs: #51107
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants