esm: fix hint on invalid module specifier #51223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
GeoffreyBooth
approved these changes
Dec 19, 2023
anonrig
reviewed
Dec 19, 2023
| '/', | ||
| ); | ||
| } else { | ||
| found = `${pathToFileURL(found)}`; |
There was a problem hiding this comment.
Nit: This might be a little bit more readable.
Suggested change
| found = `${pathToFileURL(found)}`; | |
| found = pathToFileURL(found).href; |
There was a problem hiding this comment.
I think we try to always "coerce to string" in core rather than calling the .href getter, that way if the prototype gets tampered with, all of core is affected consistently.
guybedford
reviewed
Dec 21, 2023
aduh95
force-pushed
the
fix-invalid-hint
branch
from
afafad2 to
67439d1
Compare
fix for Windows (`?` is illegal in file names apparently)
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
commented
Dec 23, 2023
aduh95
commented
Dec 23, 2023
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Dec 23, 2023
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a717fa2 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51223 Fixes: #51216 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51223 Fixes: #51216 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs are hard to work with.
Fixes: #51216