Skip to content

Conversation

atlowChemi
Copy link
Member

@atlowChemi atlowChemi commented Mar 29, 2024

This PR is a backport of #51119


PR-URL: #51119
Reviewed-By: Raz Luvaton [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Debadree Chatterjee [email protected]

H4ad and others added 3 commits March 28, 2024 16:35
PR-URL: nodejs#50074
Backport-PR-URL: nodejs#51306
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#50074
Backport-PR-URL: nodejs#51306
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#51119
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Mar 29, 2024
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@marco-ippolito
Copy link
Member

Landed in d5ac979

@marco-ippolito marco-ippolito added the backported-to-v20.x PRs backported to the v20.x-staging branch. label Apr 29, 2024
@richardlau
Copy link
Member

Landed in d5ac979

@marco-ippolito There were three commits in this PR.

@marco-ippolito
Copy link
Member

marco-ippolito commented Apr 29, 2024

Landed in d5ac979

@marco-ippolito There were three commits in this PR.

they we already pulled in v20 by another backport so I didnt duplicate them
v20.x...v20.x-staging
Is it alright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported-to-v20.x PRs backported to the v20.x-staging branch. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants