-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
repl: print errors in red #52503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: print errors in red #52503
Conversation
|
The tests failed due to them not prepared for the color scheme. I can change them once this PR is approved/reveiwed |
I don't know what others think, but I personally think that it would be best to also change the tests. |
|
The only issue with this (so far) is that when the user
But, the user would have to directly throw an object within the REPL, which almost never happens |
I'm not quite sure what went wrong here |
|
I don't think I'll end up merging this PR, as I'm trying to merge nodejs/repl into the main NodeJS, which will redo all of this anyway.
|
This change will have NodeJS REPLs print errors in red, so that they are easily distinguishable from traditional loggings. This change will not affect
console.error