esm: mordernize old tests

[puskin]

Doing a round of fast cleanup of old open and stalled PRs.
Making sure this PR is moving along addressing the comments in the original discussion.
I added the author of the original PR in the commit message.

Co-Authored-By: Jacob Smith

[simoneb]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (02b3095) to head (b0f3cc2).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54354      +/-   ##
==========================================
- Coverage   87.09%   87.09%   -0.01%     
==========================================
  Files         648      648              
  Lines      182216   182216              
  Branches    34969    34963       -6     
==========================================
- Hits       158703   158692      -11     
- Misses      16789    16796       +7     
- Partials     6724     6728       +4     

see 19 files with indirect coverage changes

[aduh95]

I've force pushed to fix the Co-Authored-By so it can be counted by our tooling as a contribution from Jacob. Note that it seems GitHub is not able to link the commit to your GitHub account – which is not at all a problem to get this landed, but maybe something you'd like to fix so the commit can be correctly credited to you.

[targos]

Note there's a typo in the commit message.

[puskin]

Yeah Jacob's email looks wrong in your commit. Any hint on how I should fix the commit message? Should I just amend? If so, which email for Jacob should I use?

When looking around I only found a "redacted" one from github

[aduh95]

Jacob's email is fine as is. It is not associated with his GitHub account but I believe that's on purpose. Our tooling does not use GitHub info to count for participation so that's not a big deal.

@puskin94 if you want to amend the commit message to fix the typo, that'd be great. At the same time, consider either changing the commit author email address to one linked with your GitHub account (currently it is giovanni dot bucci at fleetster dot net), or add the current email address to your GitHub account, or leave things as is if you're not interested in having this commit linked with your GitHub account.

[puskin]

@aduh95 I created some mess with the rebase, I wasn't able to do it because somehow the interactive one is not showing me commits happened after 60518269bc37ea78719dc50a4381d9a106a2b734 .
Having spent already too much time on this, I prefer closing this one and create a new PR from a clean slate :)