Skip to content

test: use valid hostnames #54556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2024
Merged

test: use valid hostnames #54556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/sequential/test-net-server-listen-ipv6-link-local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if (!common.hasIPv6) {
mock.method(dns, 'lookup', (hostname, options, callback) => {
callback(new Error('Mocked error'));
});
const host = 'ipv6_link_local';
const host = 'ipv6-link-local';

const server = net.createServer();

Expand All @@ -30,13 +30,13 @@ if (!common.hasIPv6) {
// Test on IPv6 Server, server.listen throws an error
{
mock.method(dns, 'lookup', (hostname, options, callback) => {
if (hostname === 'ipv6_link_local') {
if (hostname === 'ipv6-link-local') {
callback(null, [{ address: 'fe80::1', family: 6 }]);
} else {
dns.lookup.wrappedMethod(hostname, options, callback);
}
});
const host = 'ipv6_link_local';
const host = 'ipv6-link-local';

const server = net.createServer();

Expand All @@ -52,7 +52,7 @@ if (!common.hasIPv6) {
{

mock.method(dns, 'lookup', (hostname, options, callback) => {
if (hostname === 'ipv6_link_local_with_many_entries') {
if (hostname === 'ipv6-link-local-with-many-entries') {
callback(null, [
{ address: 'fe80::1', family: 6 },
{ address: 'fe80::abcd:1234', family: 6 },
Expand Down Expand Up @@ -84,7 +84,7 @@ if (!common.hasIPv6) {
}
});

const host = 'ipv6_link_local_with_many_entries';
const host = 'ipv6-link-local-with-many-entries';

const server = net.createServer();

Expand All @@ -103,11 +103,11 @@ if (!common.hasIPv6) {
// Test on IPv6 Server, picks ::1 because the other address is a link-local address
{

const host = 'ipv6_link_local_with_double_entry';
const host = 'ipv6-link-local-with-double-entry';
const validIpv6Address = '::1';

mock.method(dns, 'lookup', (hostname, options, callback) => {
if (hostname === 'ipv6_link_local_with_double_entry') {
if (hostname === 'ipv6-link-local-with-double-entry') {
callback(null, [
{ address: 'fe80::1', family: 6 },
{ address: validIpv6Address, family: 6 },
Expand Down