Skip to content

test: use platform time #54591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: use platform time #54591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e88cad4
test: use platform time
jakecastelli Aug 27, 2024
68fc01d
test: add support for riscv64
jakecastelli Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ const isOpenBSD = process.platform === 'openbsd';
const isLinux = process.platform === 'linux';
const isMacOS = process.platform === 'darwin';
const isASan = process.config.variables.asan === 1;
const isRiscv64 = process.arch === 'riscv64';
const isDebug = process.features.debug;
const isPi = (() => {
try {
Expand Down Expand Up @@ -290,6 +291,10 @@ function platformTimeout(ms) {
if (isPi)
return multipliers.two * ms; // Raspberry Pi devices

if (isRiscv64) {
return multipliers.four * ms;
}

return ms;
}

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-outgoing-end-cork.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ const common = require('../common');
const assert = require('assert');
const http = require('http');

const REQ_TIMEOUT = 500; // Set max ms of request time before abort
const REQ_TIMEOUT = common.platformTimeout(500); // Set max ms of request time before abort

// Set total allowed test timeout to avoid infinite loop
// that will hang test suite
const TOTAL_TEST_TIMEOUT = 1000;
const TOTAL_TEST_TIMEOUT = common.platformTimeout(1000);

// Placeholder for sockets handled, to make sure that we
// will reach a socket re-use case.
Expand Down