Skip to content

Conversation

benjamingr
Copy link
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Is the commit message formatted according to CONTRIBUTING.md?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

@nodejs/documentation

Description of change

Please provide a description of the change here.

Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

@thefourtheye
Copy link
Contributor

LGTM

Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
@benjamingr benjamingr force-pushed the child-process-doc-typo-fix branch from 4ecf7c8 to ec35ca0 Compare March 13, 2016 08:36
@thefourtheye thefourtheye added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Mar 13, 2016
@benjamingr
Copy link
Member Author

From what I understand there is no need to wait 48 hours to land these changes - but I'd like to wait a few hours just to be sure no one has any surprising objections.

@benjamingr
Copy link
Member Author

Noticed that I created this on the main node repo by mistake - need to get used to the new UI options - apologies.

@eljefedelrodeodeljefe
Copy link
Contributor

LGTM

benjamingr added a commit that referenced this pull request Mar 13, 2016
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
@benjamingr
Copy link
Member Author

Closed by b217460

@benjamingr benjamingr closed this Mar 13, 2016
@benjamingr benjamingr deleted the child-process-doc-typo-fix branch March 13, 2016 12:11
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
Fixes a typo in the child process docs.
Fixes: nodejs/nodejs.org#573

PR-URL: #5681

Reviewed-By: thefourtheye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants