Skip to content

Conversation

santigimeno
Copy link
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

test

Description of change

Don't check that the disconnect event is emitted before the exit
event as the order is not guaranteed.
See failing test @ https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos5-32/2648/tapTestReport/test.tap-133/

not ok 133 test-cluster-worker-kill.js
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: worker: 'exit' event before 'disconnect' event
# at Worker.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos5-32/test/parallel/test-cluster-worker-kill.js:80:12)
# at Worker.g (events.js:273:16)
# at emitTwo (events.js:100:13)
# at Worker.emit (events.js:185:7)
# at ChildProcess.<anonymous> (cluster.js:361:14)
# at ChildProcess.g (events.js:273:16)
# at emitTwo (events.js:100:13)
# at ChildProcess.emit (events.js:185:7)
# at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

@cjihrig
Copy link
Contributor

cjihrig commented Mar 20, 2016

LGTM

Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.
@santigimeno santigimeno force-pushed the fix-cluster-worker-kill branch from b43d365 to 5dae734 Compare March 20, 2016 20:47
@jbergstroem
Copy link
Member

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Mar 20, 2016
@jasnell
Copy link
Member

jasnell commented Mar 21, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 21, 2016
Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 21, 2016

Landed in 8d39481

@jasnell jasnell closed this Mar 21, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jBarz added a commit to ibmruntimes/node that referenced this pull request Feb 19, 2017
cherry-pick following from master

commit 8d39481
Author: Santiago Gimeno <[email protected]>
Date:   Sun Mar 20 21:11:36 2016 +0100

    test: fix `test-cluster-worker-kill`

    Don't check that the `disconnect` event is emitted before the `exit`
    event as the order is not guaranteed.

    PR-URL: nodejs/node#5814
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants