Skip to content

lib: fix sourcemaps with ts module mocking #58193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

lib: fix sourcemaps with ts module mocking #58193

merged 1 commit into from
May 8, 2025

Conversation

marco-ippolito
Copy link
Member

Fixes: #58119

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 6, 2025
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (7e24ebc) to head (b16d5b2).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58193      +/-   ##
==========================================
+ Coverage   90.14%   90.18%   +0.03%     
==========================================
  Files         630      630              
  Lines      186780   186789       +9     
  Branches    36654    36688      +34     
==========================================
+ Hits       168381   168458      +77     
+ Misses      11197    11125      -72     
- Partials     7202     7206       +4
Files with missing lines Coverage Δ
lib/internal/test_runner/coverage.js 73.84% <100.00%> (+9.12%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66649/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66650/

@pmarchini pmarchini added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8ccfcb5 into nodejs:main May 8, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8ccfcb5

jabari-max

This comment was marked as spam.

Sign in to view

jabari-max
jabari-max reviewed May 8, 2025
View reviewed changes
targos pushed a commit that referenced this pull request May 16, 2025
@marco-ippolito @targos
lib: fix sourcemaps with ts module mocking
868e72e 
PR-URL: #58193
Fixes: #58119
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@marco-ippolito @aduh95
lib: fix sourcemaps with ts module mocking
af7baef 
PR-URL: #58193
Fixes: #58119
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@pmarchini pmarchini pmarchini approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

+1 more reviewer

@jabari-max jabari-max jabari-max left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Report code coverage fails when using experimental mock feature

7 participants

@marco-ippolito @nodejs-github-bot @cjihrig @JakobJingleheimer @pmarchini @atlowChemi @jabari-max