Skip to content

typings: add missing typings for TypedArray #58248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

typings: add missing typings for TypedArray #58248

merged 1 commit into from
May 12, 2025
+19 −0

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented May 9, 2025 •
edited
Loading

Add missing typings for the TypedArray domain we used in the codebase.

This enables typing intellisense for typed array. e.g.

const buffer = Buffer.allocUnsafe(length); // FastBuffer extends Uint8Array
TypedArrayPrototypeFill(buffer, 0, pos, length);

will be evaluated to

const TypedArrayPrototypeFill: <FastBuffer>(self: FastBuffer, value: number, start?: number, end?: number) => FastBuffer

@jazelly jazelly changed the title typings: add typings for TypedArray typings: add missing typings for TypedArray May 9, 2025
@jazelly jazelly force-pushed the add-typed-array-types branch from 9ddbb55 to 8a59bae Compare May 9, 2025 14:02
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5b134db into nodejs:main May 12, 2025
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5b134db

targos pushed a commit that referenced this pull request May 16, 2025
@jazelly @targos
typings: add missing typings for TypedArray
d8e88f2 
PR-URL: #58248
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@jazelly @aduh95
typings: add missing typings for TypedArray
1db1c87 
PR-URL: #58248
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jazelly @nodejs-github-bot @jasnell @aduh95