Skip to content

Conversation

Renegade334
Copy link
Contributor

typings: add Atomics primordials

Note that Atomics.pause() is still flagged.

lib: prefer Atomics primordials

The majority of cases already use primordials, but there are a couple of hangovers.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. typings labels Jun 4, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (641653b) to head (34347ff).
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58577      +/-   ##
==========================================
- Coverage   90.21%   90.19%   -0.02%     
==========================================
  Files         635      635              
  Lines      187494   187488       -6     
  Branches    36838    36817      -21     
==========================================
- Hits       169144   169109      -35     
- Misses      11145    11164      +19     
- Partials     7205     7215      +10     
Files with missing lines Coverage Δ
lib/internal/test_runner/mock/loader.js 95.58% <100.00%> (-0.09%) ⬇️
lib/internal/test_runner/mock/mock.js 99.25% <100.00%> (-0.01%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented Jun 4, 2025

Can you make it two PRs? That would help with backporting (the subsystem should probably be test_runner: since it only touch those files)

aduh95 pushed a commit that referenced this pull request Jun 15, 2025
PR-URL: #58577
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Jun 15, 2025

Landed in 2d3fcf2

I've opened #58716 to land 34347ff

@aduh95 aduh95 closed this Jun 15, 2025
targos pushed a commit that referenced this pull request Jun 16, 2025
PR-URL: #58577
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@Renegade334 Renegade334 deleted the primordials-atomics branch July 16, 2025 23:08
aduh95 pushed a commit that referenced this pull request Jul 28, 2025
PR-URL: #58577
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants