Skip to content

v8: fix missing callback in heap utils destroy #58846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

v8: fix missing callback in heap utils destroy #58846

merged 2 commits into from
Jun 30, 2025

Conversation

BridgeAR
Copy link
Member

This fixes the v8.getHeapSnapshot() calls not properly being destroyed. Pipeline calls would for example not properly end without the callback being in place.

Thanks to @ronag to look into this!

@BridgeAR
v8: fix missing callback in heap utils destroy
dc84c55 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 26, 2025
Ethan-Arrowood
Ethan-Arrowood approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix lint issue and this is good to go 👍

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (d6dade5) to head (df175e2).
Report is 87 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58846      +/-   ##
==========================================
- Coverage   90.12%   90.10%   -0.03%     
==========================================
  Files         637      640       +3     
  Lines      188121   188447     +326     
  Branches    36892    36967      +75     
==========================================
+ Hits       169552   169800     +248     
- Misses      11313    11348      +35     
- Partials     7256     7299      +43
Files with missing lines Coverage Δ
lib/internal/heap_utils.js 100.00% <100.00%> (ø)

... and 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added request-ci Add this label to start a Jenkins CI on a PR. v8 module Issues and PRs related to the "v8" subsystem. labels Jun 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67672/

@BridgeAR BridgeAR added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 30, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2025
@nodejs-github-bot nodejs-github-bot merged commit c08a1d1 into nodejs:main Jun 30, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c08a1d1

targos pushed a commit that referenced this pull request Jul 3, 2025
@BridgeAR @targos
v8: fix missing callback in heap utils destroy
2b34867 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@BridgeAR @aduh95
v8: fix missing callback in heap utils destroy
2fa10e5 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@BridgeAR @aduh95
v8: fix missing callback in heap utils destroy
791ecfa 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
987d5fc 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
3a67bbf 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
5923737 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
2797154 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
5b16087 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
2e98f19 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
5418538 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
30e2504 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 26, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
a09b925 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@BridgeAR @marco-ippolito
v8: fix missing callback in heap utils destroy
077d502 
This fixes the v8.getHeapSnapshot() calls not properly being
destroyed. Pipeline calls would for example not properly end
without the callback being in place.

PR-URL: #58846
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@codebytere codebytere codebytere approved these changes

@legendecas legendecas legendecas approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BridgeAR @nodejs-github-bot @lpinca @codebytere @legendecas @Ethan-Arrowood