test: add known issue tests for fs.cp #58883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
jasnell
commented
Jun 29, 2025
jasnell
commented
Jun 29, 2025
jasnell
commented
Jun 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58883 +/- ##
==========================================
- Coverage 90.10% 90.09% -0.02%
==========================================
Files 640 640
Lines 188493 188493
Branches 36971 36972 +1
==========================================
- Hits 169843 169820 -23
- Misses 11358 11401 +43
+ Partials 7292 7272 -20 🚀 New features to boost your workflow:
|
LiviaMedeiros
approved these changes
Jun 29, 2025
jazelly
approved these changes
Jun 29, 2025
dario-piotrowicz
approved these changes
Jun 29, 2025
There was a problem hiding this comment.
LGTM 🙂
Shall we create some tests for readdir as well? (#58634 (comment))
If you prefer I can also do that as a followup (should I actually create a dedicated GitHub issue for readdir? 🤔)
|
Yeah, an issue and set of known issue tests would be good |
jasnell
added
commit-queue
VoltrexKeyva
approved these changes
Jun 29, 2025
lpinca
approved these changes
Jun 29, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2022f83 |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58883 Refs: #58634 Refs: #58869 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58883 Refs: #58634 Refs: #58869 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58883 Refs: #58634 Refs: #58869 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #58634
Refs: #58869
@nodejs/fs