-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
benchmark: adjust configuration for string-decoder bench #59187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: adjust configuration for string-decoder bench #59187
Conversation
According to nodejs#59186 this benchmark file takes 6 hours to complete a full benchmark/compare.js script (60 runs in total) and this regression tests unrealitics to do between Node.js releases. By using calibrate-n scripts I could find a better N also ajusting some bench configs. e.g: avoid dead code elimination by V8.
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "inLen" of 4096 was added at d23b7d2#diff-95e5dd48819eabf2c86b6b9c2341ea098bcf32dd2c9be1a23d1eea9dded83402R7-R17, I didn't find any reason to keep it, so LGTM.
Also, what's the new time to run this benchmark?
From 369063ms (6.15min) to 66000ms (1.06min) |
Landed in daa9e4b |
According to #59186 this benchmark file takes 6 hours to complete a full benchmark/compare.js script (60 runs in total) and this regression tests unrealitics to do between Node.js releases. By using calibrate-n scripts I could find a better N also ajusting some bench configs. e.g: avoid dead code elimination by V8. PR-URL: #59187 Refs: #59186 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
benchmark: adjust configuration for string-decoder bench
According to #59186 this benchmark file takes 6 hours to complete a full benchmark/compare.js script (60 runs in total) and these regression tests unrealitics to do between Node.js releases. By using calibrate-n scripts I could find a better N also ajusting some bench configs. e.g: avoid dead code elimination by V8.
Refs: #59186
Results from
calibrate-n.js