worker: fix worker name with \0 #59214
Open
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
fix_process_and_worker_name
branch
2 times, most recently
from
00dbad2 to
51aa926
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59214 +/- ##
==========================================
- Coverage 90.06% 90.04% -0.03%
==========================================
Files 645 648 +3
Lines 189130 191044 +1914
Branches 37094 37453 +359
==========================================
+ Hits 170339 172021 +1682
- Misses 11511 11646 +135
- Partials 7280 7377 +97
🚀 New features to boost your workflow:
|
anonrig
reviewed
Jul 25, 2025
| Environment* env, | ||
| ThreadId thread_id, | ||
| const char* url, | ||
| const std::string& name) { |
There was a problem hiding this comment.
Why not?
Suggested change
| const std::string& name) { | |
| std::string_view name) { |
There was a problem hiding this comment.
The type of name parameter has been defined as std::string& in many functions, so there are quite a few places that need to be modified.
addaleax
reviewed
Jul 25, 2025
theanarkh
force-pushed
the
fix_process_and_worker_name
branch
from
51aa926 to
27bae56
Compare
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix worker name with
\0.make -j4 test(UNIX), orvcbuild test(Windows) passes