-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
benchmark: add fs warmup to writefile-promises #59215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
benchmark: add fs warmup to writefile-promises #59215
Conversation
Review requested:
|
@RafaelGSS Could you please have a look at this? Also, one question: what do you think about removing the size: [2, 1024, 65535, 1024 * 1024], |
Yes, let's do this in another PR. Considering the results we got from this benchmark, removing the 2 from the size might be better. |
Commit Queue failed- Loading data for nodejs/node/pull/59215 ✘ Failed to get collaborator info from nodejs/node/README.md Error: Couldn't find #### TSC voting members in the README at parseCollaborators (file:///opt/hostedtoolcache/node/22.17.1/x64/lib/node_modules/@node-core/utils/lib/collaborators.js:83:11) at getCollaborators (file:///opt/hostedtoolcache/node/22.17.1/x64/lib/node_modules/@node-core/utils/lib/collaborators.js:60:21) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/22.17.1/x64/lib/node_modules/@node-core/utils/lib/pr_data.js:74:26) at async Promise.all (index 0) at async PRData.getAll (file:///opt/hostedtoolcache/node/22.17.1/x64/lib/node_modules/@node-core/utils/lib/pr_data.js:58:5) at async getMetadata (file:///opt/hostedtoolcache/node/22.17.1/x64/lib/node_modules/@node-core/utils/components/metadata.js:18:3) at async main (file:///opt/hostedtoolcache/node/22.17.1/x64/lib/node_modules/@node-core/utils/components/git/land.js:204:22)https://github.com/nodejs/node/actions/runs/16554712983 |
Add file system warmup to benchmark
writefile-promises.js