-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
test_runner: remove unused callee convertion #59221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
himself65
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
himself65:himself65/2025/07/26/remove-unused-call
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test_runner: remove unused callee convertion #59221
himself65
wants to merge
1
commit into
nodejs:main
from
himself65:himself65/2025/07/26/remove-unused-call
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59221 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.02%
==========================================
Files 648 648
Lines 191065 191064 -1
Branches 37456 37461 +5
==========================================
- Hits 172092 172056 -36
- Misses 11601 11638 +37
+ Partials 7372 7370 -2
🚀 New features to boost your workflow:
|
benjamingr
approved these changes
Jul 26, 2025
marco-ippolito
approved these changes
Jul 26, 2025
lpinca
approved these changes
Jul 26, 2025
pmarchini
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
PRs that need a full CI run.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divided from #59220.
I just realized that it's not possible to be URL
node/lib/internal/test_runner/mock/mock.js
Line 655 in 0a52a24