Skip to content

test: use mustSucceed in test-repl-tab-complete-import #59368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
+10 −19
Merged

test: use mustSucceed in test-repl-tab-complete-import #59368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions test/parallel/test-repl-tab-complete-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ const testMe = repl.start({
testMe._domain.on('error', assert.ifError);

// Tab complete provides built in libs for import()
testMe.complete('import(\'', common.mustCall((error, data) => {
assert.strictEqual(error, null);
testMe.complete('import(\'', common.mustSucceed((data) => {
publicUnprefixedModules.forEach((lib) => {
assert(
data[0].includes(lib) && data[0].includes(`node:${lib}`),
Expand All @@ -43,15 +42,14 @@ testMe.complete('import(\'', common.mustCall((error, data) => {
const newModule = 'foobar';
assert(!builtinModules.includes(newModule));
repl.builtinModules.push(newModule);
testMe.complete('import(\'', common.mustCall((_, [modules]) => {
testMe.complete('import(\'', common.mustSucceed(([modules]) => {
assert.strictEqual(data[0].length + 1, modules.length);
assert(modules.includes(newModule) &&
!modules.includes(`node:${newModule}`));
}));
}));

testMe.complete("import\t( 'n", common.mustCall((error, data) => {
assert.strictEqual(error, null);
testMe.complete("import\t( 'n", common.mustSucceed((data) => {
assert.strictEqual(data.length, 2);
assert.strictEqual(data[1], 'n');
const completions = data[0];
Expand All @@ -77,16 +75,14 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) => {
// Import calls should handle all types of quotation marks.
for (const quotationMark of ["'", '"', '`']) {
putIn.run(['.clear']);
testMe.complete('import(`@nodejs', common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete('import(`@nodejs', common.mustSucceed((data) => {
assert.deepStrictEqual(data, [expected, '@nodejs']);
}));

putIn.run(['.clear']);
// Completions should not be greedy in case the quotation ends.
const input = `import(${quotationMark}@nodejsscope${quotationMark}`;
testMe.complete(input, common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete(input, common.mustSucceed((data) => {
assert.deepStrictEqual(data, [[], undefined]);
}));
}
Expand All @@ -96,8 +92,7 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) => {
putIn.run(['.clear']);
// Completions should find modules and handle whitespace after the opening
// bracket.
testMe.complete('import \t("no_ind', common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete('import \t("no_ind', common.mustSucceed((data) => {
assert.deepStrictEqual(data, [['no_index', 'no_index/'], 'no_ind']);
}));
}
Expand All @@ -110,8 +105,7 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) => {
process.chdir(__dirname);

['import(\'.', 'import(".'].forEach((input) => {
testMe.complete(input, common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete(input, common.mustSucceed((data) => {
assert.strictEqual(data.length, 2);
assert.strictEqual(data[1], '.');
assert.strictEqual(data[0].length, 2);
Expand All @@ -121,16 +115,14 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) => {
});

['import(\'..', 'import("..'].forEach((input) => {
testMe.complete(input, common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete(input, common.mustSucceed((data) => {
assert.deepStrictEqual(data, [['../'], '..']);
}));
});

['./', './test-'].forEach((path) => {
[`import('${path}`, `import("${path}`].forEach((input) => {
testMe.complete(input, common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete(input, common.mustSucceed((data) => {
assert.strictEqual(data.length, 2);
assert.strictEqual(data[1], path);
assert.ok(data[0].includes('./test-repl-tab-complete.js'));
Expand All @@ -140,8 +132,7 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) => {

['../parallel/', '../parallel/test-'].forEach((path) => {
[`import('${path}`, `import("${path}`].forEach((input) => {
testMe.complete(input, common.mustCall((err, data) => {
assert.strictEqual(err, null);
testMe.complete(input, common.mustSucceed((data) => {
assert.strictEqual(data.length, 2);
assert.strictEqual(data[1], path);
assert.ok(data[0].includes('../parallel/test-repl-tab-complete.js'));
Expand Down
Loading