-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
test: add file attribute to JUnit reporter testcase elements #59432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59432 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 703 703
Lines 207804 207807 +3
Branches 40005 40005
=======================================
+ Hits 183989 184005 +16
+ Misses 15817 15811 -6
+ Partials 7998 7991 -7
🚀 New features to boost your workflow:
|
791f5f7
to
2473640
Compare
Force pushed to fix commit message lint error - shortened title to meet 72 character limit per Node.js contribution guidelines. |
2473640
to
70e2c68
Compare
Force pushed to fix commit message lint error - shortened title to meet 72 character limit per Node.js contribution guidelines. |
@Han5991 Thanks for the contribution! |
70e2c68
to
fa35503
Compare
Thank you! The submodule reference has been successfully changed from "test" to "test_runner" in the second commit message. |
They seem to be applied the wrong way? |
fa35503
to
25aeae1
Compare
@atlowChemi |
One of the CI jobs seems to have failed due to a flaky test. Would you mind rerunning just the failed job when you have a chance? |
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter.
Add file attribute to JUnit testcase elements when file information is available in test event data.
25aeae1
to
6509a5e
Compare
Landed in 1527825...f0aa073 |
Add file attribute normalization in JUnit test output transform to support upcoming file attribute feature in JUnit XML reporter. PR-URL: #59432 Fixes: #59422 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>
Add file attribute to JUnit testcase elements when file information is available in test event data. PR-URL: #59432 Fixes: #59422 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>
Fixes: #59422
This PR adds support for the
file
attribute in JUnit XML reporter'stestcase
elements, addressing the missing source file information that is useful for CI/CD platformslike GitLab.
Changes
file
attribute support in JUnit reporter for testcase elementsBackground
The JUnit XML specification supports a
file
attribute ontestcase
elements to indicate the source file containing the test. This attribute was missing from Node.js testrunner's JUnit output, limiting integration with tools that rely on this information for enhanced test reporting.
Before:
Testing
