-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
wasm: Revert enable JSPI as already enabled #60014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ed56d7e to
c273e58
Compare
cjihrig
approved these changes
Sep 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60014 +/- ##
==========================================
- Coverage 88.47% 88.46% -0.02%
==========================================
Files 703 703
Lines 207546 207545 -1
Branches 40006 40015 +9
==========================================
- Hits 183631 183601 -30
- Misses 15907 15946 +39
+ Partials 8008 7998 -10
🚀 New features to boost your workflow:
|
lpinca
approved these changes
Sep 25, 2025
anonrig
approved these changes
Sep 25, 2025
jasnell
approved these changes
Sep 28, 2025
guybedford
added a commit
that referenced
this pull request
Oct 1, 2025
PR-URL: #60014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 23b8340. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #59941, while keeping the test for good measure.
It turns out JSPI is already enabled on latest V8, I was just not carefully testing this between different versions.
#59941 should be considered fully reverted and backed out with this change.