Skip to content

Conversation

firedfox
Copy link
Contributor

@firedfox firedfox commented Apr 2, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

  • doc

Description of change

fixes #6008

Includes cli.markdown in all.markdown
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

/cc @Fishrock123

@jasnell jasnell added the doc Issues and PRs related to the documentations. label Apr 2, 2016
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

LGTM

@Fishrock123
Copy link
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Apr 3, 2016
Includes cli.markdown in all.markdown

PR-URL: #6011
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 3, 2016

Landed in ba0b769

@jasnell jasnell closed this Apr 3, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Includes cli.markdown in all.markdown

PR-URL: #6011
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
This was referenced Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Includes cli.markdown in all.markdown

PR-URL: #6011
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Command Line Options" document is not included in "View on single page"

5 participants