Fix events remove listener emission #60137
Open
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
removeListener
event was not being emitted when the last listener was removed from an EventEmitter.Background
When
removeListener()
is called and the last listener is removed (_eventsCount === 0
), the code path that emits theremoveListener
eventwas being skipped. This was because the emission logic was inside the
else
block of the event count check.This issue particularly affects
once()
listeners, which automatically callremoveListener()
after execution. If the once listener was thelast listener, the
removeListener
event would not fire.Changes
removeListener
event emission outside the conditional block to ensure it always executes when a listener isremoved
once()
listeners withremoveListener
event monitoringTest Plan
Related Issues
fixes: #59977