Skip to content

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Oct 9, 2025

watch is a pain to test 😿 working on it

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Oct 9, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@marco-ippolito marco-ippolito added the watch-mode Issues and PRs related to watch mode label Oct 16, 2025
@marco-ippolito marco-ippolito marked this pull request as ready for review October 16, 2025 17:28
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.56%. Comparing base (d9b8a35) to head (b335bff).
⚠️ Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60178      +/-   ##
==========================================
+ Coverage   88.54%   88.56%   +0.02%     
==========================================
  Files         703      704       +1     
  Lines      207809   208323     +514     
  Branches    40009    40032      +23     
==========================================
+ Hits       184006   184504     +498     
- Misses      15819    15861      +42     
+ Partials     7984     7958      -26     
Files with missing lines Coverage Δ
src/node_options.h 97.90% <ø> (ø)
src/node_options.cc 77.83% <0.00%> (ø)

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants