tools: add inspector_protocol updater #60245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
legendecas
force-pushed
the
tools-inspector-protocol
branch
from
2a3218c to
10630fd
Compare
cjihrig
approved these changes
Oct 13, 2025
marco-ippolito
approved these changes
Oct 13, 2025
RafaelGSS
approved these changes
Oct 13, 2025
|
Added a fixup to enable |
RaisinTen
approved these changes
Oct 14, 2025
legendecas
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60245 ✔ Done loading data for nodejs/node/pull/60245 ----------------------------------- PR info ------------------------------------ Title tools: add inspector_protocol updater (#60245) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:tools-inspector-protocol -> nodejs:main Labels meta, tools, author ready Commits 2 - tools: add inspector_protocol updater - fixup! tools: add inspector_protocol updater Committers 1 - Chengzhong Wu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60245 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60245 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Oct 2025 14:47:15 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60245#pullrequestreview-3331947289 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60245#pullrequestreview-3331948638 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60245#pullrequestreview-3332306358 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/60245#pullrequestreview-3334005131 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18533108558 |
marco-ippolito
approved these changes
Oct 15, 2025
marco-ippolito
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60245 ✔ Done loading data for nodejs/node/pull/60245 ----------------------------------- PR info ------------------------------------ Title tools: add inspector_protocol updater (#60245) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:tools-inspector-protocol -> nodejs:main Labels meta, tools, author ready, commit-queue-squash Commits 2 - tools: add inspector_protocol updater - fixup! tools: add inspector_protocol updater Committers 1 - Chengzhong Wu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60245 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60245 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Oct 2025 14:47:15 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60245#pullrequestreview-3331947289 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60245#pullrequestreview-3340907427 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60245#pullrequestreview-3332306358 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/60245#pullrequestreview-3334005131 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18533430530 |
legendecas
added
request-ci
github-actions
bot
removed
the
request-ci
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e8fd0ee |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2025
PR-URL: #60245 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls
deps/inspector_protocolwith a GHA workflow.