Skip to content

src: add a default branch for module phase #60261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

src: add a default branch for module phase #60261

merged 1 commit into from
Oct 15, 2025

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Oct 15, 2025 •
edited
Loading

This prevents a compiler warning about a missing switch-case branch when
a new ModuleImportPhase enum value is added.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7017517

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 15, 2025
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69734/

@codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.57%. Comparing base (8bc7dfd) to head (4f5b309).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/module_wrap.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60261      +/-   ##
==========================================
+ Coverage   88.54%   88.57%   +0.03%     
==========================================
  Files         704      704              
  Lines      208146   208325     +179     
  Branches    40011    40045      +34     
==========================================
+ Hits       184311   184534     +223     
+ Misses      15860    15806      -54     
- Partials     7975     7985      +10
Files with missing lines Coverage Δ
src/module_wrap.cc 75.19% <0.00%> (-0.09%) ⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69739/

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 15, 2025
@github-actions
Copy link
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1d2b89a into nodejs:main Oct 15, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1d2b89a

@legendecas legendecas deleted the module-phase branch October 15, 2025 15:49
aduh95 pushed a commit that referenced this pull request Oct 23, 2025
@legendecas @aduh95
src: add a default branch for module phase
a40e533 
PR-URL: #60261
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7017517
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Aditi Singh <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@Aditi-1400 Aditi-1400 Aditi-1400 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legendecas @nodejs-github-bot @addaleax @joyeecheung @jakecastelli @Aditi-1400