Skip to content

Conversation

@salman-aziz-4425
Copy link
Contributor

@salman-aziz-4425 salman-aziz-4425 commented Oct 17, 2025

Description

Updates the TypeScript documentation to accurately reflect Node.js's policy on decorators.

Changes

  • Removes misleading "will soon be supported" language
  • Removes "temporary limitation" claim
  • Clarifies that Node.js will not provide polyfills
  • States that decorators will be supported when implemented natively in JavaScript.

Related Issue

Fixes #60282

- Remove misleading 'soon' language
- Remove 'temporary limitation' claim
- Clarify that Node.js will not provide polyfills
- Wait for native JavaScript engine support

Refs: nodejs#60282
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 17, 2025
@marco-ippolito marco-ippolito added the strip-types Issues or PRs related to strip-types support label Oct 17, 2025
- Remove misleading 'soon' language
- Remove 'temporary limitation' claim
- Clarify that Node.js will not provide polyfills
- Wait for native JavaScript engine support
- Fix line length to meet linting requirements

Refs: nodejs#60282
@salman-aziz-4425
Copy link
Contributor Author

salman-aziz-4425 commented Oct 17, 2025

I've fixed the markdown linting error that was causing the CI to fail at linting steps

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

- Remove misleading 'will soon be supported' language
- Remove 'temporary limitation' claim
- Clarify that Node.js does not provide polyfills
- State that decorators will be supported when implemented natively
- Apply team member feedback for better clarity

Refs: nodejs#60282
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 17, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/60288
✔  Done loading data for nodejs/node/pull/60288
----------------------------------- PR info ------------------------------------
Title      doc: update decorator documentation to reflect actual policy (#60288)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     salman-aziz-4425:doc/update-decorator-documentation -> nodejs:main
Labels     doc, author ready, strip-types
Commits    3
 - doc: update decorator documentation to reflect actual policy
 - doc: update decorator documentation to reflect actual policy
 - doc: update decorator documentation to reflect actual policy
Committers 1
 - salman-aziz-4425 <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/60288
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60288
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 17 Oct 2025 07:07:14 GMT
   ✔  Approvals: 5
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60288#pullrequestreview-3349123001
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/60288#pullrequestreview-3349128914
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/60288#pullrequestreview-3349931732
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60288#pullrequestreview-3350649836
   ✔  - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/60288#pullrequestreview-3351909841
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 60288
From https://github.com/nodejs/node
 * branch                  refs/pull/60288/merge -> FETCH_HEAD
✔  Fetched commits as 481b9b11b3a9..961576e39e45
--------------------------------------------------------------------------------
[main 839cc59991] doc: update decorator documentation to reflect actual policy
 Author: salman-aziz-4425 <[email protected]>
 Date: Fri Oct 17 12:06:04 2025 +0500
 1 file changed, 2 insertions(+), 3 deletions(-)
[main 3cdb03f5b1] doc: update decorator documentation to reflect actual policy
 Author: salman-aziz-4425 <[email protected]>
 Date: Fri Oct 17 12:36:54 2025 +0500
 1 file changed, 2 insertions(+), 1 deletion(-)
[main f487e1fb2c] doc: update decorator documentation to reflect actual policy
 Author: salman-aziz-4425 <[email protected]>
 Date: Fri Oct 17 14:18:29 2025 +0500
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update decorator documentation to reflect actual policy
  • Remove misleading 'soon' language
  • Remove 'temporary limitation' claim
  • Clarify that Node.js will not provide polyfills
  • Wait for native JavaScript engine support

Refs: #60282
PR-URL: #60288
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>

[detached HEAD 6942ad7bc9] doc: update decorator documentation to reflect actual policy
Author: salman-aziz-4425 <[email protected]>
Date: Fri Oct 17 12:06:04 2025 +0500
1 file changed, 2 insertions(+), 3 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update decorator documentation to reflect actual policy

  • Remove misleading 'soon' language
  • Remove 'temporary limitation' claim
  • Clarify that Node.js will not provide polyfills
  • Wait for native JavaScript engine support
  • Fix line length to meet linting requirements

Refs: #60282
PR-URL: #60288
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>

[detached HEAD 844e2a53e5] doc: update decorator documentation to reflect actual policy
Author: salman-aziz-4425 <[email protected]>
Date: Fri Oct 17 12:36:54 2025 +0500
1 file changed, 2 insertions(+), 1 deletion(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update decorator documentation to reflect actual policy

  • Remove misleading 'will soon be supported' language
  • Remove 'temporary limitation' claim
  • Clarify that Node.js does not provide polyfills
  • State that decorators will be supported when implemented natively
  • Apply team member feedback for better clarity

Refs: #60282
PR-URL: #60288
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>

[detached HEAD 451825b2c1] doc: update decorator documentation to reflect actual policy
Author: salman-aziz-4425 <[email protected]>
Date: Fri Oct 17 14:18:29 2025 +0500
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/18627006286

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2025
@nodejs-github-bot nodejs-github-bot merged commit bbd1fa5 into nodejs:main Oct 19, 2025
34 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bbd1fa5

aduh95 pushed a commit that referenced this pull request Oct 23, 2025
- Remove misleading 'soon' language
- Remove 'temporary limitation' claim
- Clarify that Node.js will not provide polyfills
- Wait for native JavaScript engine support

Refs: #60282
PR-URL: #60288
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. strip-types Issues or PRs related to strip-types support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inaccurate Decorator Status Documentation

8 participants