-
-
Couldn't load subscription status.
- Fork 33.6k
doc: update decorator documentation to reflect actual policy #60288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update decorator documentation to reflect actual policy #60288
Conversation
- Remove misleading 'soon' language - Remove 'temporary limitation' claim - Clarify that Node.js will not provide polyfills - Wait for native JavaScript engine support Refs: nodejs#60282
|
Review requested:
|
- Remove misleading 'soon' language - Remove 'temporary limitation' claim - Clarify that Node.js will not provide polyfills - Wait for native JavaScript engine support - Fix line length to meet linting requirements Refs: nodejs#60282
|
I've fixed the markdown linting error that was causing the CI to fail at linting steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
- Remove misleading 'will soon be supported' language - Remove 'temporary limitation' claim - Clarify that Node.js does not provide polyfills - State that decorators will be supported when implemented natively - Apply team member feedback for better clarity Refs: nodejs#60282
Commit Queue failed- Loading data for nodejs/node/pull/60288 ✔ Done loading data for nodejs/node/pull/60288 ----------------------------------- PR info ------------------------------------ Title doc: update decorator documentation to reflect actual policy (#60288) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch salman-aziz-4425:doc/update-decorator-documentation -> nodejs:main Labels doc, author ready, strip-types Commits 3 - doc: update decorator documentation to reflect actual policy - doc: update decorator documentation to reflect actual policy - doc: update decorator documentation to reflect actual policy Committers 1 - salman-aziz-4425 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60288 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60288 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 17 Oct 2025 07:07:14 GMT ✔ Approvals: 5 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60288#pullrequestreview-3349123001 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/60288#pullrequestreview-3349128914 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/60288#pullrequestreview-3349931732 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60288#pullrequestreview-3350649836 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/60288#pullrequestreview-3351909841 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60288 From https://github.com/nodejs/node * branch refs/pull/60288/merge -> FETCH_HEAD ✔ Fetched commits as 481b9b11b3a9..961576e39e45 -------------------------------------------------------------------------------- [main 839cc59991] doc: update decorator documentation to reflect actual policy Author: salman-aziz-4425 <[email protected]> Date: Fri Oct 17 12:06:04 2025 +0500 1 file changed, 2 insertions(+), 3 deletions(-) [main 3cdb03f5b1] doc: update decorator documentation to reflect actual policy Author: salman-aziz-4425 <[email protected]> Date: Fri Oct 17 12:36:54 2025 +0500 1 file changed, 2 insertions(+), 1 deletion(-) [main f487e1fb2c] doc: update decorator documentation to reflect actual policy Author: salman-aziz-4425 <[email protected]> Date: Fri Oct 17 14:18:29 2025 +0500 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc: update decorator documentation to reflect actual policy
Refs: #60282
|
|
Landed in bbd1fa5 |
- Remove misleading 'soon' language - Remove 'temporary limitation' claim - Clarify that Node.js will not provide polyfills - Wait for native JavaScript engine support Refs: #60282 PR-URL: #60288 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Description
Updates the TypeScript documentation to accurately reflect Node.js's policy on decorators.
Changes
Related Issue
Fixes #60282