Skip to content

meta: loop userland-migrations in deprecations #60299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2025
Merged

meta: loop userland-migrations in deprecations #60299

merged 1 commit into from
Oct 19, 2025
+3 −0

Conversation

@legendecas
Copy link
Member

/cc @JakobJingleheimer @nodejs/userland-migrations

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 17, 2025
JakobJingleheimer
JakobJingleheimer approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 17, 2025
AugustinMauroy
AugustinMauroy approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea !

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2025
@nodejs-github-bot nodejs-github-bot merged commit 48f3c8e into nodejs:main Oct 19, 2025
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 48f3c8e

@legendecas legendecas deleted the ping-userland-migration branch October 20, 2025 09:46
aduh95 pushed a commit that referenced this pull request Oct 23, 2025
@legendecas @aduh95
meta: loop userland-migrations in deprecations
59223a7 
PR-URL: #60299
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

+3 more reviewers

@brunocroh brunocroh brunocroh approved these changes

@avivkeller avivkeller avivkeller approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.