tools: show diff alongside the error in Nix linter #60301
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
anonrig
approved these changes
Oct 17, 2025
cjihrig
approved these changes
Oct 18, 2025
lpinca
approved these changes
Oct 18, 2025
aduh95
added
author ready
benjamingr
approved these changes
Oct 19, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 21da205 |
aduh95
added a commit
that referenced
this pull request
Oct 26, 2025
PR-URL: #60301 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. in https://github.com/nodejs/node/actions/runs/18593102650/job/53012480793, the GH web UI auto focuses on the error, so it'd be more useful to show the diff there to know how to fix the error.